Re: [PATCH] drivers/net/cs89x0.c: Avoid using magic number inset_dma_mode

From: David Miller
Date: Mon Jul 06 2009 - 22:10:26 EST


From: Julia Lawall <julia@xxxxxxx>
Date: Sun, 5 Jul 2009 09:23:21 +0200 (CEST)

> The constant DMA_RX_MODE is defined to be 0x14 in the local include file
> cs89x0.h. Since a constant with the same name is used elsewhere with
> set_dma_mode, it seems likely that this constant could be used here.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/