Re: [PATCH] [x86, msr]: remove code duplication

From: H. Peter Anvin
Date: Mon Jul 06 2009 - 17:32:44 EST


Borislav Petkov wrote:
> -
> - smp_call_function_many(mask, __rdmsr_on_cpu, &rv, 1);
> + smp_call_function_single(this_cpu, msr_func, &rv, 1);
> + smp_call_function_many(mask, msr_func, &rv, 1);
> preempt_enable();

Why are you using smp_call_function_single() to execute something *on
your own CPU*?

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/