Re: [PATCH] Remove multiple KERN_ prefixes from printk formats

[Linus Torvalds]

On Mon, 6 Jul 2009, Mike Frysinger wrote:
> > Â#ifdef CONFIG_DEBUG_VERBOSE
> > - Â Â Â printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n");
> > + Â Â Â printk(KERN_EMERG "Double Fault\n");
> 
> dropped a newline.  we've largely made sure the newlines and such were
> as we want in the output ... in this case, it is not a matter of
> adding a newline where one did not exist before

Note that the 'printk' itself will add a required newline these days.

So unless you want an _empty_ line due to an earlier '\n', the change is 
correct.

If you do want the empty line, it should looke like

	printk(KERN_EMERG "\nDouble Fault\n");

but I suspect that you had the '\n' there because you had a previous 
printk which hadn't ended the line (in which case just removing it and 
relying on the KERN_EMERG causing a line break is the right thing to do).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/