Re: [tip:x86/cleanups] x86: Clean up mtrr/cleanup.c

From: Ingo Molnar
Date: Sun Jul 05 2009 - 14:05:10 EST



* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:

> On Sun, 2009-07-05 at 02:27 +0200, Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >
> > > > static struct var_mtrr_range_state __initdata range_state[RANGE_NUM];
> > > > +
> > > > static int __initdata debug_print;
> > > > +#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0)
> > > > +
> > > > +
> > >
> > > two blank lines?
> >
> > ah, yes - i moved them around.
> >
> > > > +#define BIOS_BUG_MSG KERN_WARNING \
> > > > + "WARNING: BIOS bug: VAR MTRR %d contains strange UC entry under 1M, check with your system vendor!\n"
> > >
> > > No user for this
> >
> > yeah. Mind sending a patch for these? (and any other things you
> > might notice)
>
> But why you did this stupidity.

Uhm, no. This was an unused define that i made later use of in:

e3d0e69: x86: Further clean up of mtrr/generic.c

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/