Re: [BUG] drivers/video/sis: deadlock introduced by"fbdev: add mutex for fb_mmap locking"

From: Krzysztof Helt
Date: Sun Jul 05 2009 - 10:56:36 EST


On Sun, 5 Jul 2009 07:19:33 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

>
>
> On Sun, 5 Jul 2009, Wu Zhangjin wrote:
> >
> > then it works! so, I guess there is a deadlock introduced by the above
> > commit.
>
> Hmm. Perhaps more likely, the 'mm_lock' mutex hasn't even been initialized
> yet. We appear to have had that problem with matroxfb and sm501fb, and it
> may be more common than that. See commit f50bf2b2.
>
> That said, I do agree that the mm_lock seems to be causing more problems
> than it actually fixes, and maybe we should revert it. Krzysztof?
>

I vote for fixing these drivers after my change. I will send a patch for the sis driver soon. I am building new kernel now.

Regards,
Krzysztof

----------------------------------------------------------------------
Rozwiaz krzyzowke i wygraj nagrody!
Sprawdz >> http://link.interia.pl/f2232

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/