Re: [PATCH 2/5] add buffer cache information to show_free_areas()

[Minchan Kim]

On Sun, Jul 5, 2009 at 6:24 PM, KOSAKI
Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> Subject: [PATCH] add buffer cache information to show_free_areas()
>
> When administrator analysis memory shortage reason from OOM log, They
> often need to know rest number of cache like pages.
>
> Then, show_free_areas() shouldn't only display page cache, but also it
> should display buffer cache.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> ---
> Âmm/page_alloc.c | Â Â3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: b/mm/page_alloc.c
> ===================================================================
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2118,7 +2118,7 @@ void show_free_areas(void)
> Â Â Â Âprintk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n"
> Â Â Â Â Â Â Â Â" inactive_file:%lu"
> Â Â Â Â Â Â Â Â" unevictable:%lu"
> - Â Â Â Â Â Â Â " dirty:%lu writeback:%lu unstable:%lu\n"
> + Â Â Â Â Â Â Â " dirty:%lu writeback:%lu buffer:%lu unstable:%lu\n"
> Â Â Â Â Â Â Â Â" free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
> Â Â Â Â Â Â Â Â" mapped:%lu pagetables:%lu bounce:%lu\n",
> Â Â Â Â Â Â Â Âglobal_page_state(NR_ACTIVE_ANON),
> @@ -2128,6 +2128,7 @@ void show_free_areas(void)
> Â Â Â Â Â Â Â Âglobal_page_state(NR_UNEVICTABLE),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_FILE_DIRTY),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_WRITEBACK),
> + Â Â Â Â Â Â Â K(nr_blockdev_pages()),

Why do you show the number with kilobyte unit ?
Others are already number of pages.

Do you have any reason ?


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/