Re: [tip:x86/cleanups] x86: Clean up mtrr/cleanup.c

From: Jaswinder Singh Rajput
Date: Sun Jul 05 2009 - 02:04:07 EST


On Sun, 2009-07-05 at 02:27 +0200, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> > > static struct var_mtrr_range_state __initdata range_state[RANGE_NUM];
> > > +
> > > static int __initdata debug_print;
> > > +#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0)
> > > +
> > > +
> >
> > two blank lines?
>
> ah, yes - i moved them around.
>
> > > +#define BIOS_BUG_MSG KERN_WARNING \
> > > + "WARNING: BIOS bug: VAR MTRR %d contains strange UC entry under 1M, check with your system vendor!\n"
> >
> > No user for this
>
> yeah. Mind sending a patch for these? (and any other things you
> might notice)
>

But why you did this stupidity.

I clearly specified that these are trivial clean-ups, if you found any
issue in the patch you should ping me. Instead of adding crap from your
side.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/