Re: [PATCH] vt: add an event interface

From: Alan Cox
Date: Fri Jul 03 2009 - 06:05:11 EST


> Your method leads to stuff like this in a recent commit:

Which is a cut and paste of code from the originals into the helper.

> Also note the inconsistent printk-ing lines, mutiliated by line
> warps. The use of pr_warning() would solve it:

Send patches if it bugs you that much. It's rather lower on my agenda
than pressing things like "if I do xyz to a tty then 2.6.29 crashes"
grade sutff.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/