Re: [PATCH] cgroup: Fix indent for /proc/cgroups

From: Gui Jianfeng
Date: Fri Jul 03 2009 - 05:01:09 EST


Li Zefan wrote:
> Gui Jianfeng wrote:
>> Li Zefan wrote:
>>> CC: container list
>>>
>>> Gui Jianfeng wrote:
>>>> Currently, /proc/cgroups outputs is fairly ugly as following,
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>>> indent it in a good-looking way.
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>> But if there's a subsystem with name length >= 8,
>>> it won't be aligned properly..
>> Yeap, but there isn't such a case at least by now.
>>
>
> This is not a good reason.
>
> We'll probably have such a subsystem. Actually there's a
> proposed subsystem named "maxdepth" which is of length 8.
>
> See:
> http://lkml.org/lkml/2009/7/1/581

yes, this is a case. But at least others can be aligned
properly, right? Anyway, please ignore it if you don't
like this change.

>
>
>
>

--
Regards
Gui Jianfeng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/