Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_getinterface

From: Gregory Haskins
Date: Wed Jul 01 2009 - 16:21:45 EST


Gregory Haskins wrote:
>
> + eventfd = eventfd_ctx_fileget(file);
> + if (IS_ERR(file)) {
> + ret = PTR_ERR(file);
> + goto fail;
> + }
> +
> + irqfd->eventfd = eventfd;
> +
>

<sigh>

Just noticed the typo (return "eventfd" but error-check "file"). Looks
like I will need at least a v9. Is there any other feedback before I
push out the fix for v8?

-Greg

Attachment: signature.asc
Description: OpenPGP digital signature