Re: [PATCH] kmemleak: Fix scheduling-while-atomic bug

From: Ingo Molnar
Date: Wed Jul 01 2009 - 05:30:32 EST



* Catalin Marinas <catalin.marinas@xxxxxxx> wrote:

> > The minimal fix below removes scan_yield() and adds a
> > cond_resched() to the outmost (safe) place of the scanning
> > thread. This solves the regression.
>
> With CONFIG_PREEMPT disabled it won't reschedule during the bss
> scanning but I don't see this as a real issue (task stacks
> scanning probably takes longer anyway).

Yeah. I suspect one more cond_resched() could be added - i just
didnt see an obvious place for it, given that scan_block() is being
called with asymetric held-locks contexts.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/