Re: [PATCH] net: fix race in the receive/select

From: Herbert Xu
Date: Wed Jul 01 2009 - 04:32:08 EST


On Wed, Jul 01, 2009 at 09:22:26AM +0200, Andi Kleen wrote:
>
> Agreed.
>
> I suspect the reordering of the wake queue tests might makes a difference, but
> in this case to ensure they are always tested in the proper order by
> the compiler would need more smp_rmb()s

I just looked up the original bug report and it's against RHEL4
which is a 2.6.9 kernel. Jiri, have we reproduced this on a more
recent kernel?

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/