Re: [PATCH 1/2 v2] kernel/{sched,smp}.c: fix static decl prior tostruct declaration
From: Jeff Garzik
Date: Mon May 11 2009 - 16:06:37 EST
Ingo Molnar wrote:
-tip testing found this build bug:
kernel/sched.c: In function ‘root_task_group_empty’:
kernel/sched.c:312: error: ‘root_task_group’ undeclared (first use in this function)
kernel/sched.c:312: error: (Each undeclared identifier is reported only once
kernel/sched.c:312: error: for each function it appears in.)
config attached.
Fixed and resent.
What a rat's nest of ifdefs! root_task_group is outside
CONFIG_USER_SCHED, and so I kept that property in patch v3.
However, its definition in kernel/sched.h is conditional on
CONFIG_USER_SCHED, even though root_task_group_empty() may exist outside
of CONFIG_USER_SCHED, and root_task_group is referenced vi
CONFIG_FAIR_GROUP_SCHED || CONFIG_RT_GROUP_SCHED.
Starting to wish I had never patched this code in the first place (that
barb is directed at the code, not you...)
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/