Re: [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section

From: Cyrill Gorcunov
Date: Sat Apr 18 2009 - 23:49:49 EST


On 4/19/09, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> tip-bot for Cyrill Gorcunov wrote:
>> Commit-ID: 1f51f72326c4d16f402bdfed99c8dae20eb67863
>> Gitweb:
>> http://git.kernel.org/tip/1f51f72326c4d16f402bdfed99c8dae20eb67863
>> Author: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
>> AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
>> Committer: Ingo Molnar <mingo@xxxxxxx>
>> CommitDate: Sat, 18 Apr 2009 22:58:58 +0200
>>
>> x86: smpboot - wakeup_secondary should be done via __cpuinit section
>>
>> A caller (do_boot_cpu) already has __cpuinit attribute.
>>
>> Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
>> lead to panic at moment.
>>
>> [ Impact: cleanup ]
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
>> LKML-Reference: <20090418194528.GD25510@lenovo>
>> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>>
>>
>> ---
>> arch/x86/kernel/smpboot.c | 4 ++--
>
> there are other two in numaq and es7000.
>
> can you fix them too?
>
> YH
>
>
Will do tomorrow morning
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/