Re: [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE

[Mathieu Desnoyers]

* Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> On Thu, Apr 16, 2009 at 11:35:38PM -0700, Jeremy Fitzhardinge wrote:
> > -DEFINE_TRACE(power_mark);
> > +DEFINE_TRACE(power_mark,
> > +	TP_PROTO(struct power_trace *it, unsigned int type, unsigned int state),
> > +	      TP_ARGS(it, type, state));
> 
> Wrong indentation, the TP_ARGS should have the same level of indentation
> (one) as the TP_PROTO.  Also true for all others.
> 

Ingo actually proposed to add a supplementary indentation before TP_ARGS
in trace/sched.h to ease readability.

Mathieu

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/