Re: TOMOYO in linux-next

[Pavel Machek]

Hi!

> As for the rest of the feedback, please work with the developers to fix 
> any bugs or lack of documentation.

Apparently not even its user<->kernel interface was reviewed. This
violates "one value per file in sysfs":

    [root@tomoyo]# cat /sys/kernel/security/tomoyo/meminfo
    Shared:       61440
    Private:      69632
    Dynamic:        768
    Total:       131840
    
    You can set memory quota by writing to this file.
    (Example)
    [root@tomoyo]# echo Shared: 2097152 > /sys/kernel/security/tomoyo/meminfo
    [root@tomoyo]# echo Private: 2097152 > /sys/kernel/security/tomoyo/meminfo

(not to mention being ugly as hell).

This is totaly useless once tomoyo is merged:

    ** /sys/kernel/security/tomoyo/version **
    
    This file is used for getting TOMOYO Linux's version.
    (Example)
    [root@etch]# cat /sys/kernel/security/tomoyo/version
    2.2.0-pre


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/