Re: [PATCH 14/18] Blackfin Serial Driver: use the DLAB macro tohide variant differences

[Andrew Morton]

On Fri,  6 Mar 2009 14:42:56 +0800
Bryan Wu <cooloney@xxxxxxxxxx> wrote:

> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
> 
> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> ---
>  drivers/serial/bfin_5xx.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> index b89861d..71a9e6b 100644
> --- a/drivers/serial/bfin_5xx.c
> +++ b/drivers/serial/bfin_5xx.c
> @@ -1250,7 +1250,7 @@ struct console __init *bfin_earlyserial_init(unsigned int port,
>  void bfin_serial_debug(const char *fmt, ...)
>  {
>  	struct bfin_serial_port *uart = &bfin_serial_ports[0];
> -	unsigned short status, tmp;
> +	unsigned short status;
>  	unsigned long flags;
>  	int i, count;
>  	char buf[128];
> @@ -1273,11 +1273,7 @@ void bfin_serial_debug(const char *fmt, ...)
>  			status = UART_GET_LSR(uart);
>  		} while (!(status & THRE));
>  
> -#ifndef CONFIG_BF54x
> -		tmp = UART_GET_LCR(uart);
> -		tmp &= ~DLAB;
> -		UART_PUT_LCR(uart, tmp);
> -#endif
> +		UART_CLEAR_DLAB(uart);
>  		UART_PUT_CHAR(uart, buf[i]);
>  		if (buf[i] == '\n') {
>  			do {

This appears to be a small cleanup, not a bugfix.

I'm OK with sneaking the odd non-bugfix into late -rc by accident -
it's not teribly important, and getting the main bugs fixed overwhelms
such considerations.

However I have a sneaky suspicion that this patch might actually fix a
bug, only we weren't told about it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/