Re: [PATCH mainline] menu: fix embedded menu snafu

From: Andrew Morton
Date: Mon Mar 02 2009 - 19:17:35 EST


On Mon, 2 Mar 2009 14:14:06 -0800
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> The COMPAT_BRK kconfig symbol does not depend on EMBEDDED,
> but it is in the midst of the EMBEDDED menu symbols, so it mucks
> up the EMBEDDED menu. Fix by moving it to just after all of
> the EMBEDDED menu symbols. Also, surround all of the
> EMBEDDED symbols with "if EMBEDDED"/"endif" so that this
> EMBEDDED block is clearer.

This patch causes weird unintended breakage, methinks.

x86_64 allnoconfig does:

mm/bootmem.c: In function 'mark_bootmem':
mm/bootmem.c:321: warning: control reaches end of non-void function

because

}
BUG();
}

gets preprocessed down to

}
;
}

because all BUG-related config options got removed:

akpm2:/usr/src/25> make allnoconfig
scripts/kconfig/conf -n arch/x86/Kconfig
#
# configuration written to .config
#
akpm2:/usr/src/25> grep BUG .config
CONFIG_X86_DEBUGCTLMSR=y
# CONFIG_INPUT_EVBUG is not set
# CONFIG_DEBUG_FS is not set
# CONFIG_DEBUG_KERNEL is not set
CONFIG_DEBUG_MEMORY_INIT=y


I think I'll wait for version 2...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/