Re: [PATCH] modpost: Check the section flags, not name, to catchmissing "ax"/"aw"

[H. Peter Anvin]

Anders Kaseorg wrote:
> On Tue, 24 Feb 2009, H. Peter Anvin wrote:
>> This is a pretty critical set of warnings, that often represent real 
>> bugs.  I don't think it's acceptable to lose them.  However, you already 
>> have (prior in the sequence) changed those section names to not conflict 
>> with the automatically generated ones, so it seems to me that this 
>> should be fixable without too much pain.
> 
> Actually, the problem arises from a conflict between two classes of 
> automatically generated section names, one from ld, and one from gcc.  
> Instead of basing the warning on section names (the existing heuristic 
> also fails to warn on some cases where it should, as it turns out), what 
> do you think about this patch?  I've tested that it still triggers the 
> warning when an "ax" or "aw" is incorrectly removed, and it should handle 
> even more cases than before.
> 

Seems reasonable to me.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/