Re: [PATCH 13/16] kprobes: fix sparse warnings: Using plain integer as NULL pointer

From: Hannes Eder
Date: Thu Feb 26 2009 - 20:14:14 EST


[Added To]

On Sun, Feb 22, 2009 at 1:05 AM, Hannes Eder <hannes@xxxxxxxxxxxxxx> wrote:
> Fix this sparse warnings:
>  kernel/test_kprobes.c:118:19: warning: Using plain integer as NULL pointer
>  kernel/test_kprobes.c:213:22: warning: Using plain integer as NULL pointer
>  kernel/test_kprobes.c:326:22: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hannes Eder <hannes@xxxxxxxxxxxxxx>
> ---
>  kernel/test_kprobes.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/test_kprobes.c b/kernel/test_kprobes.c
> index 4f10451..9a43351 100644
> --- a/kernel/test_kprobes.c
> +++ b/kernel/test_kprobes.c
> @@ -115,7 +115,7 @@ static int test_kprobes(void)
>        int ret;
>        struct kprobe *kps[2] = {&kp, &kp2};
>
> -       kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> +       kp.addr = NULL; /* addr should be cleard for reusing kprobe. */
>        ret = register_kprobes(kps, 2);
>        if (ret < 0) {
>                printk(KERN_ERR "Kprobe smoke test failed: "
> @@ -210,7 +210,7 @@ static int test_jprobes(void)
>        int ret;
>        struct jprobe *jps[2] = {&jp, &jp2};
>
> -       jp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> +       jp.kp.addr = NULL; /* addr should be cleard for reusing kprobe. */
>        ret = register_jprobes(jps, 2);
>        if (ret < 0) {
>                printk(KERN_ERR "Kprobe smoke test failed: "
> @@ -323,7 +323,7 @@ static int test_kretprobes(void)
>        int ret;
>        struct kretprobe *rps[2] = {&rp, &rp2};
>
> -       rp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> +       rp.kp.addr = NULL; /* addr should be cleard for reusing kprobe. */
>        ret = register_kretprobes(rps, 2);
>        if (ret < 0) {
>                printk(KERN_ERR "Kprobe smoke test failed: "
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/