Re: [PATCH] perfcounters: fix a few minor cleanliness issues

From: Arnd Bergmann
Date: Thu Feb 26 2009 - 08:42:25 EST


On Thursday 26 February 2009, Paul Mackerras wrote:
> This fixes three issues noticed by Arnd Bergmann:
>
> - Add #ifdef __KERNEL__ and move some things around in perf_counter.h
>   to make sure only the bits that userspace needs are exported to
>   userspace.
>
> - Use __u64, __s64, __u32 types in the structs exported to userspace
>   rather than u64, s64, u32.
>
> - Make the sys_perf_counter_open syscall available to the SPUs on
>   Cell platforms.
>
> And one issue that I noticed in looking at the code again:
>
> - Wrap the perf_counter_open syscall with SYSCALL_DEFINE4 so we get
>   the proper handling of int arguments on ppc64 (and some other 64-bit
>   architectures).
>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>

Thanks for the follow-up!

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/