Re: [PATCH 1/4] uaccess: add copy_word_from_user

From: H. Peter Anvin
Date: Wed Feb 25 2009 - 21:06:38 EST


Steven Rostedt wrote:
This patch creates a copy_word_from_user function that can copy
a space delimited word from user space. This puts the code in
a new lib/uaccess.c file. This keeps the code in a single location
and may be optimized in the future.

I have a bit of an issue with the naming... at least *I* read this as copying a machine word, which made me wonder why you didn't just use "get_user". I would suggest copy_token_from_user or something like that.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/