Re: [PATCHSET x86/core/percpu] improve the first percpu chunk allocation

From: Rusty Russell
Date: Wed Feb 25 2009 - 01:40:46 EST


On Wednesday 25 February 2009 07:46:59 Ingo Molnar wrote:
> kernel/trace/trace_functions_graph.c: In function âgraph_trace_closeâ:
> kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function âpercpu_freeâ
>
> that's free_percpu() now, right?
>
> Btw., why was this rename done? We generally standardize on
> hierarchical names, going from the more general to the more
> specific names, left to right.

Agreed, but we had both, doing identical things, and free_percpu outnumbered
percpu_free by a significant factor (about 40 to 5 IIRC).

Simple pragmatism, and it matches alloc_percpu.
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/