Re: [PATCH 14/16] dma-debug: add checks for sync_single_sg_*

From: Joerg Roedel
Date: Sun Jan 11 2009 - 03:00:34 EST


On Sun, Jan 11, 2009 at 12:46:41AM +0100, Ingo Molnar wrote:
>
> * Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
>
> > +void debug_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg,
> > + int nelems, int direction)
> > +{
> > + struct scatterlist *s;
> > + int i;
> > +
> > + if (global_disable)
> > + return;
>
> "if (unlikely(global_disable))" i suspect?

True. I will add unlikely() to all global_disable checks.

Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/