Re: [fix] Too async libata breakage

From: Tejun Heo
Date: Fri Jan 09 2009 - 05:11:38 EST


Hello,

Justin P. Mattock wrote:
> Linus Torvalds wrote:
>> On Thu, 8 Jan 2009, Justin P. Mattock wrote:
>>
>>> O.K. attached is the results of
>>> dmesg after doing a git-pull
>>> (system didn't freeze, but there's
>>> a slew of warnings); i.g.
>>>
>>
>> That's a different thing now - some very annoying warnings indeed.
>>
>> Tejun, I think it's yours. And I think it should be removed, or at the
>> very least changed into a WARN_ON_ONCE. Because spamming the console
>> with this is not a good idea:

Yeah, that's WARN_ON() on a pretty hot path. I'll submit a patch to
convert it to WARN_ON_ONCE() but that's a condition which shouldn't
happen in the first place. Strange.

Justin, can you please post the output of "lspci -nn" and full kernel
boot log?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/