Re: [PATCH] x86: traps.c replace #if CONFIG_X86_32 with #ifdefCONFIG_X86_32

From: Chuck Ebbert
Date: Tue Dec 23 2008 - 15:34:28 EST


On Tue, 23 Dec 2008 10:20:37 -0800
"H. Peter Anvin" <hpa@xxxxxxxxxx> wrote:

> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -692,7 +692,7 @@ void math_error(void __user *ip)
> >
> > err = swd & ~cwd & 0x3f;
> >
> > -#if CONFIG_X86_32
> > +#ifdef CONFIG_X86_32
> > if (!err)
> > return;
> > #endif
>
> Applied to tip:x86/fpu, thanks.
>
> Andi: you might have a perspective on this: in math_error() we bail out
> if there is no error on i386, but not on x86-64. I am rather assuming
> that is because it simply can't happen on x86-64 (no IRQ 13 bullshit) so
> it wasn't necessary?
>

Some 32-bit x86 clones generate math error interrupts when there is no
actual error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/