[PATCH] p54usb: Fix regression when using LM87 firmware

From: Larry Finger
Date: Sat Dec 20 2008 - 14:01:22 EST


From: Christian Lamparter <chunkeey@xxxxxx>

Commit 2b80848e3818fb1c8ccddc105b065a86c68afa9d entitled "p54usb: support LM87
firmwares" resulted in a regression when LM87 firmware is used, as this
firmware needs an explicit termination "packet" to terminate the transmission.
If this is missing, the device stalls. This problem is reported as Bugzilla
Entry No. 12260.

The original patch was suitable for the wireless-testing.git tree. This version
is designed for 2.6.28-rc9.

Signed-off-by: Christian Lamparter <chunkeey@xxxxxx>
Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
---

John,

This patch should be sent to 2.6.28, preferably before release.

Larry
---

Index: linux-2.6/drivers/net/wireless/p54/p54usb.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/p54/p54usb.c
+++ linux-2.6/drivers/net/wireless/p54/p54usb.c
@@ -251,6 +251,7 @@ static void p54u_tx_lm87(struct ieee8021
usb_sndbulkpipe(priv->udev, P54U_PIPE_DATA), hdr,
len + sizeof(*hdr), free_on_tx ? p54u_tx_free_cb : p54u_tx_cb,
dev);
+ data_urb->transfer_flags |= URB_ZERO_PACKET;

usb_submit_urb(data_urb, GFP_ATOMIC);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/