Re: [PATCH] x86: process.c declare c1e_remove_cpu before they getused

[Ingo Molnar]

* Jaswinder Singh <jaswinder@xxxxxxxxxxxxx> wrote:

> On Thu, 2008-12-18 at 13:36 +0100, Ingo Molnar wrote:
> 
> > hm, why is this needed? Have you seen a compiler warning?
> > 
> 
> I was getting :
> 
>   CHECK   arch/x86/kernel/process.c
> arch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?
> 
> Thank you,

ah, good. Feel free to include such information in future patches. I've 
applied your patch to tip/x86/cleanups, thanks! See below how the final 
commit looks like - added the sparse warning as well.

	Ingo

--------------->