Re: [RFC PATCH 20/26] UBIFS: add VFS operations

[Pekka Enberg]

Hi Artem,

On Thu, Mar 27, 2008 at 5:55 PM, Artem Bityutskiy
<Artem.Bityutskiy@xxxxxxxxx> wrote:
>  +static int ubifs_set_page_dirty(struct page *page)
>  +{
>  +       /*
>  +        * An attempt to dirty a page without budgeting for it - should not
>  +        * happen.
>  +        */
>  +       ubifs_assert(0);
>  +       return __set_page_dirty_nobuffers(page);
>  +}
>  +
>  +static int ubifs_releasepage(struct page *page, gfp_t unused_gfp_flags)
>  +{
>  +       /*
>  +        * An attempt to release a dirty page without budgeting for it - should
>  +        * not happen.
>  +        */
>  +       ubifs_assert(PageLocked(page));
>  +       if (PageWriteback(page))
>  +               return 0;
>  +       ubifs_assert(PagePrivate(page));
>  +       ubifs_assert(0);
>  +       ClearPagePrivate(page);
>  +       ClearPageChecked(page);
>  +       return 1;
>  +}

So you don't expect the VM to ever call these functions? Why?

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/