David Miller wrote:From: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Tue, 23 Oct 2007 22:20:30 -0400
David Miller wrote:Looks great:From: Jeff Garzik <jeff@xxxxxxxxxx>Seems sane to me. Something like this (attached)?
Date: Tue, 23 Oct 2007 21:03:36 -0400
I'm wondering if there is a way to avoid addingThe first idea I get is:
to every ethernet driver's ->open() hook.
1) Create netdev->validate_dev_addr().
2) If it exists, invoke it before ->open(), abort
and return if any errors signaled.
etherdev init hooks up a function that does the above
check, which allows us to avoid editing every ethernet
What do you think?
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
I like it.
Should I start sending patches to remove the checks from e1000/e1000e/ixgb/ixgbe
already (to David, I assume?)?