Re: [patch] pm: include EIO from errno-base.h

From: David Brownell
Date: Mon Apr 30 2007 - 10:51:30 EST


On Monday 30 April 2007, David Rientjes wrote:
> call_platform_enable_wakeup() uses EIO, so it needs to be defined.
>
> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

Actually, in that PM-is-disabled case returning zero (success)
rather than -EIO would have been the backwards-compatible
approach ... the hook not being there shouldn't be an error.
And returning zero wouldn't require this #include either...

- Dave


> ---
> include/linux/pm.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>
> #include <linux/list.h>
> #include <asm/atomic.h>
> +#include <asm/errno.h>
>
> /*
> * Power management requests... these are passed to pm_send_all() and friends.
>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/