Re: checkpatch, a patch checking script.

From: Jeff Garzik
Date: Sat Apr 28 2007 - 14:12:43 EST


Dave Jones wrote:
On Sat, Apr 28, 2007 at 03:02:13AM -0700, Andrew Morton wrote:

> This little checking tool should have both "error" and "warning" levels -
> AKA "fix this" and "think about this" levels. BUG_ON would be a warning
> thing.

There's a -pedantic option there just for this. I'll move BUG_ON under it.
What's the consensus on the u32 thing, move that too, or drop completely?

Not answering your question directly, but FWIW: In day to day coding and email, I strongly advocate the use of u8/u16/u32 over the C99 size-based types.

Simple, direct (read: easiest to review), and less typing.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/