Re: checkpatch, a patch checking script.

From: Andrew Morton
Date: Sat Apr 28 2007 - 04:17:36 EST


On Sat, 28 Apr 2007 10:01:00 +0200 (MEST) Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:

> And since when is uint32_t wrong? What makes u32 or __u32 better?

There's not much to be said in favour of u32, really. Except it's shorter
and I can never remember where the underscore goes in uint_32t.

If kernel used u_int32_t globally then the world would probably be a better
place. But using just the one name has its advantages from a consistency
POV.

box:/usr/src/linux-2.6.21> grep -r '[ \(]u32' . | wc -l
39599
box:/usr/src/linux-2.6.21> grep -r '[ \(]uint32_t' . | wc -l
5132

CodingStyle permits either variant, fwiw.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/