Re: [GIT-PULL] please pull UBI tree

From: Andrew Morton
Date: Fri Apr 27 2007 - 16:53:27 EST


On Fri, 27 Apr 2007 09:00:25 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 27 Apr 2007, Artem Bityutskiy wrote:
> >
> > Linus, please, pull UBI tree from
> > git://git.infradead.org/ubi-2.6.git for-linus
> >
> > The UBI tree has been in -mm for several releases and we would like to
> > see it in the mainline.
>
> Quite frankly, I have absolutely _zero_ visibility into things like this,
> so before I merge it I want ack's from various layers (preferably a
> mixture of interests - are any vendors interested, is DavidW ok with this,
> who is using it now and are the interfaces and designs correct etc etc?)
>
> So I simply cannot make that decision. I don't have the expertise or the
> knowledge. I'll have to trust somebody else for things like this, and it
> should be somebody who isn't "personally involved".
>
> In other words, I kind of want a sign-off from other parties, because I
> can't pull things like this "blind".
>
> Are there (embedded?) vendors that already integrate this into their
> kernel, or wait for it? Is dwmw supportive of this? Questions, questions..

The patchset used to contain lots of debugging support which wildly
duplicated thigs which we already did and was generally overdone. That
appears to all have been cleaned up now, so thanks for doing that.

The one remaining nit I'd have with the debug code is that it adds a
private hexdump() facility. By my count, that is the kernel's eighth
hexdump implementation. There may be even more which don't have "hexdump"
in their name.

lib/hexdump.c is rather overdue.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/