Re: pgprot_writecombine() and PATs on x86

From: Eric W. Biederman
Date: Wed Apr 25 2007 - 14:37:14 EST


Andi Kleen <ak@xxxxxxx> writes:

> On Wednesday 25 April 2007 20:02:26 Roland Dreier wrote:
>> Hi Eric,
>>
>> Where do your patches to add an implementation of
>> pgprot_writecombine() using PATs on x86 stand?
>
> It's on my todo list.

Basically enabling PAT is easy. Adding the paranoid checks is
trickier. I keep intending to do something but...

>> The mlx4 driver I'm
>> planning on merging for 2.6.22 would really like writecombining, and
>> I'm interested in doing the work to finally get the PAT stuff merged
>> (probably for 2.6.23 I guess).
>>
>> Just to give a little background on my motivation: the mlx4 hardware
>> allows a page in its PCI space to be mapped, where the driver can write
>> descriptors and payloads directly, instead of ringing a doorbell and
>> having the HW fetch the descriptor from system memory, for better latency.
>
> When it's PCI space you can likely just use MTRRs. PAT is mostly useful
> for applications that do IO with random memory pages

The problem is that on machines with larger memory configurations (8-12G)
there are no spare mtrrs, or the mtrrs can frequently be configured in
an overlapping way so that we can't set them up. In general mtrrs
work ok for one card possible for two and after that they are just
useless.

PAT is also much easier to use from a driver perspective, and it is
much more portable between architectures. Using mtrrs from drivers
is almost impossible.

Roland is the mlx4 sane enough to put the memory that needs
write-combining a prefetchable bar. So several cards can be combined
together?

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/