Re: [PATCH] Transparently handle <.symbol> lookup for kprobes

[Paul Mackerras]

Srinivasa Ds writes:

> +	} else {							\
> +		char dot_name[KSYM_NAME_LEN+1];				\
> +		dot_name[0] = '.';					\
> +		dot_name[1] = '\0';					\
> +		strncat(dot_name, name, KSYM_NAME_LEN);			\

Assuming the kernel strncat works like the userspace one does, there
is a possibility that dot_name[] won't be properly null-terminated
here.  If strlen(name) >= KSYM_NAME_LEN-1, then strncat will set
dot_name[KSYM_NAME_LEN-1] to something non-null and won't touch
dot_name[KSYM_NAME_LEN].

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/