Re: [PATCH 2.6.19 5/5] fs: freeze_bdev with semaphore not mutex
From: Alasdair G Kergon
Date: Tue Nov 07 2006 - 19:02:30 EST
On Wed, Nov 08, 2006 at 12:42:02AM +0100, Rafael J. Wysocki wrote:
> On Wednesday, 8 November 2006 00:18, Eric Sandeen wrote:
> > But, how is a stampede of fs-freezers -supposed- to work? I could
> > imagine something like a freezer count, and the filesystem is only
> > unfrozen after everyone has thawed? Or should only one freezer be
> > active at a time... which is what we have now I guess.
> I think it shouldn't be possible to freeze an fs more than once.
In device-mapper today, the only way to get more than one freeze on the
same device is to use xfs and issue xfs_freeze before creating an lvm snapshot
(or issuing the dmsetup equivalent), and at the moment we tell people not to do
that any more. The device-mapper API does not permit multiple freezes of the
same device. (The interesting question is actually whether the request should
be cascaded in any way when devices depend on other devices.)
Now if someone's introducing a new use for freeze_bdev, perhaps now's the time
to revisit the semantics and allow for concurrent freeze requests.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/