Re: KDB blindly reads keyboard port
From: Luck, Tony
Date: Fri Sep 29 2006 - 14:02:48 EST
On Fri, Sep 29, 2006 at 10:57:41AM -0600, Bjorn Helgaas wrote:
> acpi_parse_fadt: acpi_kbd_controller_present 0
The logic in the kernel seems backwards here though. We start
by assuming there is a keyboard, then when parsing the FADT
we reset this assumption if the BAF_8042_KEYBOARD_CONTROLLER
bit isn't set. Which in turn forced SGI to include some
workaround code for their older PROM (which doesn't provide
the FADT table).
There's also a risk that if some code might get added that
runs before we parse FADT that could be confused into thinking
that the keyboard is present.
Wouldn't it be simpler/better to assume there is no keyboard until
we find positive evidence that there is one?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/