Re: pcmcia oops on 2.6.17-rc
From: Linus Torvalds
Date: Mon May 15 2006 - 19:37:53 EST
On Tue, 16 May 2006, Alan Cox wrote:
> It would certainly be a lot cleaner than this sort of code in the pcmcia
> core right now. Want me to send a patch which only allows for SA_SHIRQ
> and WARN_ON()'s for any driver not asking for shared IRQ ?
I think it's too late for that in the current series, but yes, we could do
it for 2.6.18.
There are a few valid reasons for not using SA_SHIRQ, but they tend to be
really special. Ie you'd better _know_ that you're either some system
device, or you're physically in an ISA slot, not just based on some old
ISA design. And PCMCIA is no longer an excuse, exactly because of some
systems that will route even the 16-bit interrupts through a PCI irq.
So anything in arch/ is likely ok (for example, the vm86 interrupt
handling on x86 had _better_ be an exclusive interrupt ;)
Doing a quick grep shows a surprising amount of drivers that pass in zero,
but I guess that they truly _are_ old ISA sound/networking drivers.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/