Re: [PATCH] pci_ids: remove non-referenced symbols from pci_ids.h
From: Dave Jones
Date: Sun Oct 30 2005 - 23:15:44 EST
On Mon, Oct 31, 2005 at 02:38:13PM +1100, Grant Coady wrote:
> > This patch is removing some PCI idents from drivers that are currently
> > marked BROKEN on some/all architectures. It seems counterproductive
> > to create even more work to get those drivers fixed.
> Nobody cares, the drivers are dying of bit-rot :)
Remove the BROKEN, and it builds, and runs just fine on most systems.
(Or it least it did, until this intentional breakage occured).
> > Especially in the case of for eg, the advansys scsi driver, which
> > actually works for some people, even though it isn't updated to use
> > modern scsi layer interfaces.
> Any positive suggestions?
Yes. Don't remove symbols that are referenced by code in the rest of the
tree (even if it isn't buildable). It's not as though leaving those
symbols there breaks anything, or even bloats the kernel.
> How many years does a driver remain broken before it gets removed? These
> drivers don't compile cleanly thus are not in use, no? Perhaps a set of
> patches scheduling removal is in order.
At least 2 distros are carrying patches removing the BROKEN attribute
on the advansys Kconfig for some architectures. The users of those kernels
using their advansys controllers without any issue at all.
Even if this were not the case, randomly removing bits of a driver so that
it has no chance of working isn't how we schedule removal.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/