Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
From: john stultz
Date: Thu Oct 20 2005 - 15:05:28 EST
On Thu, 2005-10-20 at 21:32 +0200, Ingo Molnar wrote:
> * john stultz <johnstul@xxxxxxxxxx> wrote:
> > > > John, would this cause any problems to keep cycle_t at s64?
> > >
> > > I mean at u64.
> > Performance would be the only concern. It had been a u64 before I
> > started optimizing the code a bit.
> no, this is really a bad optimization that causes unrobustness.
> Correctness and robustness comes first. It is so easy to cause a
> 500-1000msec delay in the kernel, due to a bad driver or anything. The
> timekeeping code should not break like that.
Eh, its an easy enough change, so I'll put it back to u64. We can
revisit it again later if needed.
However making sure periodic_hook isn't starved for too long is
important for good timekeeping, since ntp and cpufreq adjustments are
made at that point. Steven's suggestion of moving it to use ktimers
sounds like a good plan, but let me know if you can see any other holes.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/