Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
From: Jim Ramsay
Date: Tue Sep 06 2005 - 14:02:30 EST
Regarding the sata_promise.c patch, I think I have found a bug in the
Just before the 'try_hotplug' label, you provide a check that will
kick us out of the interrupt handler if the interrupt was just handled
by a DMA command completing successfully.
However, I have seen the occasion where a single IRQ is used to signal
both a DMA completion AND a hotplug event. Of course in this case the
hotplug event itself would be ignored completely.
So I would recommend getting rid of that check entirely.
"Me fail English? That's unpossible!"
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/