Re: [PATCH 188.8.131.52] NPTL signal delivery deadlock fix
From: Chris Wright
Date: Wed Aug 17 2005 - 14:01:52 EST
* Bhavesh P. Davda (bhavesh@xxxxxxxxx) wrote:
> This bug is quite subtle and only happens in a very interesting
> situation where a real-time threaded process is in the middle of a
> coredump when someone whacks it with a SIGKILL. However, this deadlock
> leaves the system pretty hosed and you have to reboot to recover.
> Not good for real-time priority-preemption applications like our
> telephony application, with 90+ real-time (SCHED_FIFO and SCHED_RR)
> processes, many of them multi-threaded, interacting with each other for
> high volume call processing.
Nice catch, also looks like something for -stable series. Roland, any
issue with this patch?
> diff -Naur linux-184.108.40.206/kernel/signal.c linux-220.127.116.11-sigfix/kernel/signal.c
> --- linux-18.104.22.168/kernel/signal.c 2005-08-14 18:20:18.000000000 -0600
> +++ linux-22.214.171.124-sigfix/kernel/signal.c 2005-08-17 11:36:20.547600092 -0600
> @@ -686,7 +686,7 @@
> struct task_struct *t;
> - if (p->flags & SIGNAL_GROUP_EXIT)
> + if (p->signal->flags & SIGNAL_GROUP_EXIT)
> * The process is in the middle of dying already.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/