Re: [PATCH3/5] Synchronize patch for SAA7134 cards

[David Liontooth]

Andrew Morton wrote:

>Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxx> wrote:
>  
>
>>--- linux-2.6.12/drivers/media/video/saa7134/saa7134-video.c	2005-06-07 15:39:55.000000000 -0300
>>+++ linux/drivers/media/video/saa7134/saa7134-video.c	2005-06-12 01:22:34.000000000 -0300
>>@@ -1,5 +1,5 @@
>> /*
>>...
>> 		.h_start       = 0,
>> 		.h_stop        = 719,
>>- 		.video_v_start = 23,
>>- 		.video_v_stop  = 262,
>>- 		.vbi_v_start_0 = 10,
>>- 		.vbi_v_stop_0  = 21,
>>- 		.vbi_v_start_1 = 273,
>>- 		.src_timing    = 7,
>>-
>>+		.video_v_start = 22,
>>+  		.video_v_start = 23,
>>    
>>
>
>That doesn't compile.  I'll assume it's supposed to be 22.
>  
>
Wrong, use 23. In fact don't apply this patch; it's a dud.

Michael Schimek's vbi changes got messed up somewhere along the line.
It should be 23, not 22 as you understandably assume -- Michael included this note in his patch:

+/* mhs 2005-05-14: Properly video capturing should start in line 22,
+   but for some reason video task A will not execute without a one
+   line gap after vbi task A/B ends, if that is enabled. */

With 22, turning on ntsc closed captioning on saa7134 cards will block the video.

Dave

>--
>video4linux-list mailing list
>Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
>https://www.redhat.com/mailman/listinfo/video4linux-list
>  
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/