Re: [PATCH] possible error in EXIT_DEAD transformation

From: Ingo Molnar
Date: Tue Jun 14 2005 - 09:53:15 EST



* Joe Korty <joe.korty@xxxxxxxx> wrote:

> This assignment may have been missed, when TASK_DEAD was
> converted over to EXIT_DEAD.

> @@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:
> spin_lock_irq(&rq->lock);
>
> if (unlikely(prev->flags & PF_DEAD))
> - prev->state = EXIT_DEAD;
> + prev->exit_state = EXIT_DEAD;

no, here we set the dead task's state to EXIT_DEAD, so that it does not
come back on the runqueue. Its ->exit_state is already EXIT_DEAD (or
EXIT_ZOMBIE).

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/