Re: [netfilter-core] Re: [PATCH] Avoid unncessary checksum validationin TCP/UDP netfilter

From: Patrick McHardy
Date: Sun Jun 12 2005 - 10:08:02 EST


Keir Fraser wrote:
> On 27 May 2005, at 12:20, Phil Oester wrote:
>> On Fri, May 27, 2005 at 12:03:08PM +0100, Keir Fraser wrote:
>>
>>> The TCP/UDP connection-tracking code in netfilter validates the
>>> checksum of incoming packets, to prevent nastier errors further down
>>> the road. This check is unnecessary if the skb is marked as
>>> CHECKSUM_UNNECESSARY.
>>
>> It seems at least part of this has already been merged in 2.6.12-rc
>
> It would be great if the UDP code also would observe
> CHECKSUM_UNNECESSARY. I'll wait for 2.6.12 to appear and then submit a
> new patch if UDP has been missed.

TCP was changed to fix a regression with loopback packets. I've added
the UDP part of your patch to my 2.6.13 tree.

Regards
Patrick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/