Assuming NULL

[Jan Engelhardt]

Hi developers,



some places in fs/*.c have conditions like

(namei.c, 238, in "int permission()"):
        if(inode->i_op && inode->i_op->permission)

Others just have
(namei.c, 813, in "int fastcall link_path_walk()"):
        if(!inode->i_op->lookup)

My question is: Which one is right wrt the case "i_op ==/!= NULL"?
There are two ways:

- the kernel assumes i_op (and similar) is always non-NULL
  => then we can remove a lot of checks, like the first example above

- the kernel does not assume...
  => then we need some extra checks, like in the second example above



Jan Engelhardt                                                               
--                                                                            
| Gesellschaft fuer Wissenschaftliche Datenverarbeitung Goettingen,
| Am Fassberg, 37077 Goettingen, www.gwdg.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/