Re: [PATCH] vfs: namei operations should pass nameidata when available

From: Christoph Hellwig
Date: Fri Jun 10 2005 - 15:10:57 EST


On Fri, Jun 10, 2005 at 12:05:11PM -0700, Ram wrote:
> On Mon, 2005-03-28 at 12:17, Christoph Hellwig wrote:
> > > + dentry = __lookup_hash(&nd->last, nd->dentry, nd);
> >
> > Please add a tiny wrapper lookup_hash_nd(struct nameidata *nd)
> > that expands to the above instead of opencoding it everywhere.
> >
> > Or just call it lookup_hash() after you removed the original version..
>
> Jeff,
>
> I have incorporated the Christophs' comments.
> lookup_hash() now takes a third
> nameidata argument. I touch tested it. If you like the patch can
> your forward it to Andrew.

No, please wait. I have a patch series pending for post 2.6.12 that
revamps this code area little, lookup_hash will only take a nameidata *
after that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/