Re: [PATCH 00/10] IOCHK interface for I/O error handling/detecting

[Hidetoshi Seto]

Hi Ben,

Benjamin Herrenschmidt wrote:
> > > - Additionally adds special token - abstract "iocookie" structure
> > >  to control/identifies/manage I/Os, by passing it to OS.
> > >  Actual type of "iocookie" could be arch-specific. Device drivers
> > >  could use the iocookie structure without knowing its detail.
> >
> > I'm not sure we need this.  Surely it can be deduced from the pci_dev or
> > struct device?
>
> Might be useful to know more though, wether it was PIO or MMIO or other
> things. Also, I'd like to carry around the possible error details as can
> be returned by the firmware in some platforms.
>
> In fact, Is there any reason this is not ioerr_cookie instead of
> iocookie ? :)

To be honest, No :)
Or is there any reason to limit use of this cookie only for errors?

Thanks,
H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/