Re: [GIT PATCH] Another PCI fix for 2.6.12-rc6

From: Narendra Sankar
Date: Thu Jun 09 2005 - 18:00:23 EST


David S. Miller wrote:

From: "Narendra Sankar" <nsankar@xxxxxxxxxxxx>
Date: Thu, 09 Jun 2005 15:48:28 -0700



So it would still be useful to have this patch in, would it not?



Absolutely, the patch should go in.

I just want to make sure the descrepency between the two Broadcom
drivers gets resolved. TG3 does a MSI correctness check, BNX2
does not. And this is what doesn't make any sense.



Actually looking at the bnx2.c code from jeffG 2.6.13 git tree, it seems that it also tests for MSIs being delivered.

So both tg3 and bnx2 test for MSI correctness.

My original comment when submitting the patch, was under the assumption that these tests were not being done. However that code has got added to both drivers.

Naren

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/